This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
.NET 8 PR [Merge on 11/14] #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated dotnet version to build
…otnet-architecture/eShopOnWeb into v-sruspasari/dotnet8_migration
…_migration Migrated to dotnet 8 and Updated packages.
bbrandt
reviewed
Nov 16, 2023
Directory.Packages.props
Outdated
| @@ -1,7 +1,11 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | |||
| <TargetFramework>net7.0</TargetFramework> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
| <AspNetVersion>8.0.0-rc.2.23480.2</AspNetVersion> | |||
There was a problem hiding this comment.
These version numbers can now be 8.0.0 now, right?
Update Directory.Packages.props
WeihanLi
reviewed
Dec 8, 2023
Comment on lines
58
to
60
| <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.6.3" /> | ||
| <PackageVersion Include="xunit" Version="2.4.2" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5"> |
There was a problem hiding this comment.
Maybe we could have these test reference updated also
There was a problem hiding this comment.
I will create another issue for this.... just to verify any changes
|
The default port changed from 80 to 8080 for containers, see details here: https://learn.microsoft.com/en-us/dotnet/core/compatibility/containers/8.0/aspnet-port while it seems we do not have any changes about that, we may need some changes to keep the container working |
|
@WeihanLi fixed up ;) good catch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.